Open
Conversation
added 2 commits
April 23, 2018 13:36
before:
Imp: 0x10a451d40 Signature: void ^();
after:
Imp: 0x10a451d40 Signature: void ^() Variables : {
<ViewController: 0x7fdd9b204060>
<AppDelegate: 0x60c00002acc0>
};
kastiglione
reviewed
May 19, 2018
Contributor
kastiglione
left a comment
kastiglione
left a comment
There was a problem hiding this comment.
Thanks! This is a nice addition. I have some questions.
| NSMutableDictionary *dict = (id)[NSMutableDictionary dictionary]; | ||
|
|
||
| [dict setObject:(id)[NSNumber numberWithLong:(long)real.invoke] forKey:@"invoke"]; | ||
| [dict setValue:(id)[NSNumber numberWithLong:(long)real.invoke] forKey:@"invoke"]; |
Contributor
There was a problem hiding this comment.
why the change to setValue:forKey:?
Author
commands/FBClassDump.py
Outdated
| json.update(variables_json) | ||
|
|
||
| variablesStrs = [] | ||
| for i in range(10): |
commands/FBClassDump.py
Outdated
| print 'Imp: ' + hex(json['invoke']) + ' Signature: ' + sigStr | ||
| print 'Imp: ' + hex(json['invoke']) + ' Signature: ' + sigStr + ' Variables : {\n'+variablesStr+'\n};' | ||
|
|
||
| def getBlockVariables(self, block, min_var_count=1, max_var_count=20): |
Contributor
There was a problem hiding this comment.
can you explain min_var_count and max_var_count? I'm not clear on their purpose.
Author
|
@kastiglione the related code |
|
I think this is super useful! Is this something that is still in progress? If not, I'd be happy to take a stab at the implementation myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:
Imp: 0x10a451d40 Signature: void ^();
after:
Imp: 0x10a451d40 Signature: void ^() Variables : {
<ViewController: 0x7fdd9b204060>
<AppDelegate: 0x60c00002acc0>
};